Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bug with sandbox reload when url parameters are provided #16551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented May 1, 2025

Fix #16549

The main issue is that React props are being reset by the component update code and things go awry. I moved all the props to global state so that we can modify it when it actually should be modified.

@bjsplat
Copy link
Collaborator

bjsplat commented May 1, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 1, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16551/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16551/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16551/merge/?snapshot=refs/pull/16551/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

@bghgary bghgary marked this pull request as ready for review May 2, 2025 15:46
@deltakosh deltakosh merged commit 03bd683 into BabylonJS:master May 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script error message when pressing R a few times in the sandbox
3 participants