Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pass "allowCanvas" into override serialize functions. #16553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

jamessimo
Copy link
Contributor

Fixes a bug with instances of BabylonJS running in a "Canvas-less" environment crashing when trying to serialize buttons.

Right now, when using the serialize() function in buttons, they ignore the "allowCanvas" parameter which was added in #15033

Link to BabylonJS Forum discussion:
https://forum.babylonjs.com/t/skip-canvas-being-used-during-control-serialize/49302/13?u=jamessimo

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) May 2, 2025 15:34
@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 2, 2025

auto-merge was automatically disabled May 5, 2025 13:19

Head branch was pushed to by a user without write access

@bjsplat
Copy link
Collaborator

bjsplat commented May 5, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented May 5, 2025

@RaananW RaananW merged commit c6e3fc7 into BabylonJS:master May 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants