BVH loader loadAsserContainerAsync support
#16565
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16565/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16565/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16565/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
cc @yuripourre |
|
Nice! |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
| @@ -82,7 +82,7 @@ export class BVHFileLoader implements ISceneLoaderPluginAsync, ISceneLoaderPlugi | |||
| geometries: [], | |||
| lights: [], | |||
| spriteManagers: [], | |||
| }); | |||
| } as ISceneLoaderAsyncResult); | |||
There was a problem hiding this comment.
Why the as? Is it just for intellisense? If so it seems like satisfies would make more sense here since the intent is not to cast.
from #16540
In the current BVH loader, the skeleton will be added to the scene twice when load with
loadAssetContainerAsync.To solve this, I applied the same approach as the gltf loader's Skeleton creation method.
https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/loaders/src/glTF/2.0/glTFLoader.ts#L1378-L1381