Allow moving engines when using offline storage #16567
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16567/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16567/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16567/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
There are a few issues addressed here.
The first - this issue cannot be reproduced on the playground because of the
indexOf(".babylon"). In this case any file hostes on our CDNs will be "true", as it has.babylonjs.comin the URL.The second - when NOT in the playground, WebGPU loads images as array buffers whereas WebGL engine loads images as Blobs. This is the way they are stored in the DB. So when WebGPU is the first engine, the data is stored as array buffer. Now, when moving to WebGL2 engine, the data will be loaded as ArrayBuffer and not a Blob.
This PR adds 2 fallbacks - if the file loaded is a blob and array buffer is needed, it does that, and if the image is loaded and requires a Blob, it will create a blob if the data is an ArrayBuffer.
Solving https://forum.babylonjs.com/t/switching-engines-vs-createobjecturl/58247?u=raananw