Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Playground load #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Playground load #2004

merged 2 commits into from
Apr 13, 2017

Conversation

Jaskar
Copy link
Contributor

@Jaskar Jaskar commented Apr 13, 2017

When user doesn't specify an iteration (link like /#123456) , get the first iteration (/#123456#0) saved, not the last. Asked by @davrous

@deltakosh deltakosh merged commit 37ced33 into BabylonJS:master Apr 13, 2017
@aWeirdo
Copy link
Contributor

aWeirdo commented Apr 15, 2017

Sorry to bump this up, but i was thinking,

If you increase the "iteration" to a higher number than there is saved/available,
right now it will redirect to "http://www.babylonjs-playground.com/"
why not redirect to the highest available?

E.g,
If you go to;
http://www.babylonjs-playground.com/#JZRDRD#1
Increase it from # 1 to # 2 & update and it will redirect you to http://www.babylonjs-playground.com/

Thought it could be a nice and quick way to find the newest update to a PG by just having to add # 999 or something and it would redirect you to the highest available for the PG.

@deltakosh
Copy link
Contributor

really like the idea! Fancy doing a PR?

@aWeirdo
Copy link
Contributor

aWeirdo commented Apr 15, 2017

I don't know much about the PG code tbh, but i took a quick look at the publicly available files,
However i don't see any back-end files anywhere and I think it would be most optimal to do it when querying for a snippet,
so when querying, if the version is higher than 0 but doesn't exist, return highest available.

@deltakosh
Copy link
Contributor

the code is here: https://github.com/BabylonJS/Documentation-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants