Can you please be more specific about the warning you are trying to fix?

It is warning C4702. If I try to build xml_parsing.cpp in release mode on MSVC I get this:

1>d:\projects\behaviortree.cpp\src\xml_parsing.cpp(326): error C2220: warning treated as error - no 'object' file generated
1>d:\projects\behaviortree.cpp\src\xml_parsing.cpp(326): warning C4702: unreachable code

This for-loop always throws an error (both the if- and else-block). Because of this the "child = child->NextSiblingElement()" part is never executed, which MSVC does not like.

for (auto child = node->FirstChildElement(); child != nullptr;
                 child = child->NextSiblingElement())
            {
                if( StrEqual(child->Name(), "remap") )
                {
                   ThrowError(node->GetLineNum(), "<remap> was deprecated");
                }
                else
		{
                    ThrowError(node->GetLineNum(), "<SubTree> should not have any child");
                }
            }

just pushed a different solution. Thanks for contributing :)