Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix catkin build for v3 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

Fix catkin build for v3 #169

merged 1 commit into from
Apr 2, 2020

Conversation

AlexisTM
Copy link
Contributor

@AlexisTM AlexisTM commented Apr 2, 2020 •
edited
Loading

This allows the v3 to be built with catkin (I tested catkin_tools on ROS 1).

The setup:

  • OS: Ubuntu 18.04
  • ROS version: Melodic
  • Architecture: x64
  • Build type: catkin_tools

Without the fix, it returns:

[build] Warning: Skipping package `behaviortree_cpp_v3` because it has an unsupported package build type: `ament_cmake`

I believe that conditionals are not supported in catkin, yet, having both build_type makes it work for catkin.

As: build_x64/behaviortree_cpp_v3/catkin_generated/stamps/behaviortree_cpp_v3/package.xml.stamp

<?xml version="1.0"?>
<package format="3">
  <name>behaviortree_cpp_v3</name>
  <version>3.3.0</version>
  <description>
  This package provides the Behavior Trees core library.
  </description>

  <maintainer email="[email protected]">Davide Faconti</maintainer>

  <license>MIT</license>

  <author>Michele Colledanchise</author>
  <author>Davide Faconti</author>

  <buildtool_depend condition="$ROS_VERSION == 1">catkin</buildtool_depend>
  <depend condition="$ROS_VERSION == 1">roslib</depend>

  <buildtool_depend condition="$ROS_VERSION == 2">ament_cmake</buildtool_depend>
  <depend condition="$ROS_VERSION == 2">rclcpp</depend>

  <depend>libzmq3-dev</depend>

  <export>
      <build_type condition="$ROS_VERSION == 1">catkin</build_type>
      <build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>
  </export>

</package>

@facontidavide facontidavide merged commit c34a79b into BehaviorTree:master Apr 2, 2020
@facontidavide
Copy link
Collaborator

thanks

@AlexisTM AlexisTM deleted the fix/catkin_build_v3 branch April 2, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexisTM @facontidavide