refactor: update bookCover method signature and implementation#102
Merged
Conversation
Contributor
A1nair
commented
Dec 4, 2025
- Change bookCover to accept title, isbn, and docNumber parameters
- Update all call sites in borrow_info_card, book_info_card, and book_detail_card
- Improve API consistency for fetching book cover images
- Change bookCover to accept title, isbn, and docNumber parameters - Update all call sites in borrow_info_card, book_info_card, and book_detail_card - Improve API consistency for fetching book cover images
Owner
|
Remains a problem: book cover reload when page changed. Getting book cover URL now costs many time, so it is necessary to fetch it while fetching borrow list. I will fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.