Improve Resolution config entry, use it to override resolution#7
Merged
ManlyMarco merged 4 commits intoBepInEx:masterfrom Sep 19, 2025
daydensteve:master
Merged
Improve Resolution config entry, use it to override resolution#7ManlyMarco merged 4 commits intoBepInEx:masterfrom daydensteve:master
ManlyMarco merged 4 commits intoBepInEx:masterfrom
daydensteve:master
Conversation
… as opposed to using the maximum resolution of the current monitor
…ibly set the resolution. Useful primarily for any game where the game uses hardcoded resolution settings and ignores changes made by this plugin in previous sessions.
ManlyMarco
requested changes
Sep 9, 2025
Member
ManlyMarco
left a comment
There was a problem hiding this comment.
- Can you separate the Reset button fix into another PR? Also it's probably better to only store the original resolution just before applying our own custom resolution, just in case the game goes through multiple different resolutions as it loads configs and such.
- I think useResolutionConfig is unnecessary, simply check if the resolution setting has a value in it or if it's empty.
- Ideally the override could be enabled from the UI, maybe add a toggle to the custom drawer that makes the resolution be saved in the setting?
Contributor
Author
|
requested changes made. I agree thats much cleaner. Will submit a separate PR for the reset change after merge |
ManlyMarco
approved these changes
Sep 19, 2025
Member
ManlyMarco
left a comment
There was a problem hiding this comment.
Looks good, thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a game where it would always load at 1080x1920 regardless of changes made via this plugin in previous sessions. Modifying the plugin felt like the easiest path forward to force it up to 4k.
These changes affect the behavior of the Resolution settings in the following ways:
Regarding #3, I went this route instead of always using the value so I could maintain previous functionality and not change how the plugin works in every use case, thereby limiting - if not eliminating - unintended consequences of the change. If maintainers would prefer to always use it, I welcome the edits.