Test with Julienne #251
Test with Julienne #251
Conversation
There was a problem hiding this comment.
@rouson it appears you've inadvertently committed three copies of the GASNet install tree to this PR branch, which makes it very difficult to review the PR and probably at least partially explains the CI failures. These stray directories must be deleted from the branch and squashed out of the git history, to ensure these binaries don't eventually end up merged and bloat the Caffeine git repo.
Would you like to address that chore or shall I?
|
@bonachea Oops! Sorry. Please fix this when you have time -- no rush. |
This commit adds a test-suite driver, test/julienne/driver.f90, with supporting tests for the following subroutines: - prif_co_broadcast - prif_co_min - prif_co_max - prif_image_queries - prif_init - prif_num_images - prif_this_image_no_coarray - prif_sync_images All new tests are in test/julienne. All tests pass. TODO: restrict output to image 1 chore: rm redundant tests This commit removes veggies tests for the following subroutines because they are now redundant with the correspondiong julienne tests added in a prior commit: - prif_co_broadcast - prif_co_max - prif_co_min - prif_image_queries - prif_num_images - prif_sync_images - prif_this_image This commit retains the redundant prif_init test becuase it is presumalby needed for the proper launch of the veggies tests. build(fpm.toml.template): add Julienne 3.0.0 dep test(co_sum): add julienne test, rm veggies test test(co_reduce): add julienne test|rm veggies test chore: non_overridable test_t child type-bnd-procs fix(image_queries_test): add closing parens test: add prif_coarray_inquiry_test_m fix: rm binary chore: rm veggies prif_coarray_inquiry_test fix(test/julienne): support GCC 13 - 14.2 chore: rm reference to deleted veggies test chore: rm partially complete julienne test build(include): fix macro logic/syntax test(julienne): append to diagnostics strings This commit appends the text from veggies assertions "message" argument to test diagnoses in the corresponding Julienne tests. For example, a veggies assertion of the form assert_equals(actual, expected, message) becomes a Julienne test diagnosis of the following form: (actual .equalsExpected. expected) // message Remove inadvertently added GASNet install trees
|
I removed the GASNet install trees, but now I notice other stray files that appear to have also been inadvertently added. I'll assume I also have your permission to remove those. |
|
@bonachea I fixed the issue that was causing failures. All tests pass now. This PR is ready for review. |
…iew and maintenance There are zero code changes in this commit
|
As discussed in our meeting today, We can always rename files later in a subsequent PR that omits content changes, assuming there's a compelling motivation for it. CI tests are still passing, and I hope to find time to review this PR next week. |
|
@bonachea sounds good. I really like Caffeine's coding conventions and hadn't noticed them before. |
This PR
test/juliennethat replace corresponding veggies tests intest/.test/julienne/driver.F90.The decision about which tests to prioritize for transitioning first was driven by file size with the work progressing from the smallest file to the largest file. A couple of relatively minor features have been added in Julienne 3.1.0 in order to support Caffeine, but there no known issues preventing continuing this process with the remaining tests. At this point, the only known hurdle is available developer time.