Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ic 7439 - #272

Open
Rapternmn wants to merge 6 commits into
BinPy:developfrom
Rapternmn:add_IC_7439
Open

Add ic 7439#272
Rapternmn wants to merge 6 commits into
BinPy:developfrom
Rapternmn:add_IC_7439

Conversation

@Rapternmn

Copy link
Copy Markdown
Contributor
  • Added IC_7439
  • Added tests for IC_7439

I have sent a few pull requests for ICs but unfortunately,some dont pass the test..and on IC_7407,no test has been run..i am unable to figure out what was wrong..

I have edited a few example documents and sent a pull request..please see if the changes made are valid so that i can edit the other example documents..

@ghost

ghost commented Oct 8, 2014

Copy link
Copy Markdown

@Rapternmn Try to implement all the 7400 ic's you wish to do so in a single PR .. makes it easier for you to test / for us to review / keep track of the progress .. :) Check the red x mark to see log on why it failed ... If it looks like the failure is a generic one ... ( due to AnalogBuffers, or IC 4070 etc ... ) try restarting that build alone !

@Rapternmn

Copy link
Copy Markdown
Contributor Author

Okk..what about the example documents..
I changed set_IC,draw_IC..etc etc
Please tell me whether i should do it for all documents or no

@ghost

ghost commented Oct 8, 2014

Copy link
Copy Markdown

The way to update these examples is :

  • Use IPython notebook and edit the examples and make sure the entire notebook runs perfectly one last time by "Restart kernel" followed by "Cell --> Run All"
  • Use the download as feature to get the python code and rst file and update them in respective locations ...
  • Add, commit and push all your changes to the PR's branch
  • Call @debugger22 or @sarwarc to update the sphinx docs :P

Follow this for all examples !

This way you get to update / edit the code only once !

@ghost

ghost commented Oct 8, 2014

Copy link
Copy Markdown

And to answer your question on whether the changes need to be done ... Yeah !!

@ghost

ghost commented Oct 8, 2014

Copy link
Copy Markdown

If possible close #271 #270 #269 #268 and push their code to this PR itself ... Try to use minimal no. of commits and readable commit messages ( ic: Added IC 7400; Added tests and examples for the same etc . . .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant