modified invalid min/max terms error - #289
Open
yashu-seth wants to merge 1 commit into
Open
Conversation
yashu-seth
force-pushed
the
fixes_in_make_boolean_function
branch
from
October 6, 2015 10:20
2acc307 to
063feac
Compare
Contributor
Author
|
@OrkoHunter @salil93 @rvraghav93 please have a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that on giving the following input -
The following output comes -
Which is ambiguous. I know the input itself is flawed but I think on giving such input error should be displayed and not an ambiguous result.
Please look into it.
If you find the change reasonable, kindly inform me so that I will edit the tests as well.