Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix page sections layout#100

Merged
bitbager merged 2 commits into
BitBagCommerce:masterfrom
victordit:master
Nov 23, 2017
Merged

fix page sections layout#100
bitbager merged 2 commits into
BitBagCommerce:masterfrom
victordit:master

Conversation

@victordit
Copy link
Copy Markdown

No description provided.

</div>
</div>
{% if null != page.products %}
{% if (page.products|length) > 0 %}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the bracket?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but why ? fix CS?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of our coding standard, we don't use brackets if not necessary.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done! :)

@bitbager
Copy link
Copy Markdown
Member

Thanks!

@bitbager bitbager merged commit 8c3bdde into BitBagCommerce:master Nov 23, 2017
bitbager pushed a commit that referenced this pull request Jul 16, 2018
Bring 1.1/master fixes to 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants