Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Block][Page] Switch to strict types#24

Merged
bitbager merged 4 commits into
BitBagCommerce:devfrom
shinoks:dev
Sep 13, 2017
Merged

[Block][Page] Switch to strict types#24
bitbager merged 4 commits into
BitBagCommerce:devfrom
shinoks:dev

Conversation

@shinoks
Copy link
Copy Markdown
Contributor

@shinoks shinoks commented Sep 13, 2017

No description provided.

public function setContent($content);
public function setContent(?string $content): void;

/**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ImageInterface|null

$this->content = $content;
}

/**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you switch @mixed to {@inheritdoc}?

public function getImage(): ?ImageInterface;

/**
* @param ImageInterface $image
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ImageInterface|null

Comment thread src/Entity/Page.php Outdated
}

/**
* @return PageTranslationInterface|TranslationInterface
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageTranslationInterface|TranslationInterface or null 😄

@bitbager bitbager changed the title [Block Page] Switch to strict types [Block][Page] Switch to strict types Sep 13, 2017
@bitbager bitbager merged commit 34e84ca into BitBagCommerce:dev Sep 13, 2017
@bitbager
Copy link
Copy Markdown
Member

Thank you, Paweł! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants