This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Kralux patch 2 #225
Merged
Kralux patch 2 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some information because I think it is needed since I first got confused while writing my code. I thought utxo() would return the CONFRIMED TXs and unconfirmed() would return the unconfirmed TXs so I initially called BOTH methods only to realize I had duplicate TXIDs since utxo() generates both. One can only figure that out after running the code since it does not explicitly state that. Hopefully this will help other devs in the future. I also added some explanations to the utxo object structure for people not familiar with it since it may save them time...
Fixed input format mismatch with the output format of the example
added more explanation on how to use the sign() method because it is not clear for a new user how to use it on multiple inputs.
added link to WIF format because most people won't remember it by heart and will need to look it up.
added another link simply describing steps to go from PK to WIF
added detail since it refuses non-compressed private keys.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more description and links to documentation.
Added more description in the returned object because a lot of it is implicit and hard to know ahead of time without trying it.
Also fixed small errors in the examples.
We need as much info as possible because for a first-timer, this is really hard to get into with the sparse description we currently have.