Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better documentations#18

Merged
tesar-tech merged 3 commits into
BlazorStatic:masterfrom
junovell:better-docs
Jul 6, 2024
Merged

Better documentations#18
tesar-tech merged 3 commits into
BlazorStatic:masterfrom
junovell:better-docs

Conversation

@junovell

Copy link
Copy Markdown
Contributor

clean and improve the documentations

TODO

  • rewrite the main readme
  • rewrite the new-start file (change it to in-depth-guide?)
  • verify grammar and vocabulary.

is there anything else i forgot about?

@netlify

netlify Bot commented Jun 25, 2024

Copy link
Copy Markdown

Deploy Preview for blazorstatic ready!

Name Link
🔨 Latest commit b3aaa26
🔍 Latest deploy log https://app.netlify.com/sites/blazorstatic/deploys/6681875358e3600008fb0ba1
😎 Deploy Preview https://deploy-preview-18--blazorstatic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@junovell

Copy link
Copy Markdown
Contributor Author

I tried to keep the main Readme as simple and straightforward as possible.

@tesar-tech tesar-tech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is a much better version. It is not an easy task to explain things to people from the position of someone who understands it well. Thanks for the contribution.

Comment thread README.md Outdated
It automatically discovers pages to generate by scanning for the `@page` directive in Razor files, but It only targets non-parametrized pages (e.g., `@page "/mypage"`, not `@page "/mypage/{param}"`).

BlazorStatic is a small library designed for integration into Blazor applications. Here are a few straightforward methods to get started:
### Features

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also second level heading here? ##

Comment thread README.md
### Features

### Fork or clone BlazorStaticMinimalBlog
- Easily parse and consume markdown files.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how brief and on point it is!

Comment thread README.md Outdated
app.UseBlazorStaticGenerator(shutdownApp: !app.Environment.IsDevelopment());
```
- `shutdownApp` is essential for CI/CD pipelines to prevent indefinite running.
#### Cloning the project

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put this in main "how to" guide. It makes it look complicated.

@junovell

Copy link
Copy Markdown
Contributor Author

It just occured to me, Should I add a "limitations" section below the features?

@tesar-tech

Copy link
Copy Markdown
Collaborator

It just occured to me, Should I add a "limitations" section below the features?

Hm, probably yes, some sort of..

But what are the limitations? Limitations of static site generator in general? Limitations like "missing features"? I would name it in more positive manner, something like: "Coming soon", etc..
Or a different kind of limitations?

@junovell

Copy link
Copy Markdown
Contributor Author

I meant like a warning to inform users that this library cannot convert their c# code to JavaScript, so if they have any interactive component that relies on c# it won't work.

@tesar-tech

Copy link
Copy Markdown
Collaborator

I think it's not necessary. This is already an "issue" with SSR and people who are willing to use any static site generator do understand that.

@tesar-tech tesar-tech marked this pull request as ready for review July 6, 2024 11:23
@tesar-tech tesar-tech merged commit c366f0e into BlazorStatic:master Jul 6, 2024
@tesar-tech

Copy link
Copy Markdown
Collaborator

Thanks for it.

I have done some edits after.
Now it all should be all more understandable for other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants