better solution to register pages to generate as static files#20
Conversation
✅ Deploy Preview for blazorstatic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- updated README.md - drafted release blog post
There was a problem hiding this comment.
We also shoudl rename https://github.com/tesar-tech/BlazorStatic/blob/237bacd20c6061b0293c395060d7bfd49215089e/src/BlazorStaticOptions.cs#L29 (see the one comment about naming)... And probably also remove the https://github.com/tesar-tech/BlazorStatic/blob/237bacd20c6061b0293c395060d7bfd49215089e/src/BlazorStaticOptions.cs#L38 since it has no use, because it scan the whole assembly. Could that have some implications? Can you think of an example where people don't want pages from the whole assembly? (in that case the proposed "IgnoredRazorPages" would make sense )
merge with remote
- minor fixes and comments
|
I think we are done here, or do you see anything else to consider? |
|
looks good, you can merge it |
better solution to generate routes, this would also eliminate the need for
BlazorStaticOptions.RazorPagesPathsPros:
@attribute [Route(...)]Cons: