tags improvements - non-url characters#48
Merged
Conversation
Collaborator
Author
|
Please do add your authorship to the beta.14 blog post if you want. |
…e repo ownership transfer.
✅ Deploy Preview for blazorstatic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Have you thought about the idea of taxonomies instead of just having tags, such as how Hugo handles this? I think to just get Tags working well you could stick to this implementation and add a Tag class, but it might make sense to consider a higher level abstraction like Taxonomy that defaults to having Tag and Category classes, but could be extended to have user-implemented ones as well. |
Collaborator
Author
|
Merging this for now and will finish it it other pr that goes bit deeper into the structure.. The tags are bit wrong with all the ContentService and options, so I am fixing it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #46
opt.TagEncodeFuncin program.cs.to discussion:
Tagsare defined as List of strings, but maybe it would be more convenient to keep them asList<Tag> Tagswhere:This would force users to use correct version when working with tag..
That would be quite a breaking change since the Tags are defined in
IFrontMatter.