Feat-surreal-alternative-adapter #79
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c501991 in 47 seconds
More details
- Looked at
3155lines of code in42files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/unit/queries/query.test.ts:1
- Draft comment:
The import path forinitis incorrect. It should be two levels up, not one. Please update the import statement to correctly reference theinitfunction from thehelpersdirectory.
import { init } from '../../helpers/init';
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_yS0PBRHisu8go5lP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 40c819d in 1 minute and 19 seconds
More details
- Looked at
1614lines of code in28files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/unit/mutations/allMutation.test.ts:1
- Draft comment:
This file is redundant as it only imports and runs functions that are already being tested in their respective test files. Consider removing this file to avoid duplication and potential confusion. - Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_oLfZgJwXRpwxLM2S
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on e4b95b7 in 34 seconds
More details
- Looked at
55lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_LkQSmDiVtrrSkIxP
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const thing = getSchemaByThing(ctx.schema, q.$thing); | ||
| const { id } = thing.defaultDBConnector; | ||
|
|
||
| if (thing.db === 'typeDB') { |
There was a problem hiding this comment.
It seems there's a mix-up in the database checks for typeDB and surrealDB. The conditions and associated logic appear to be reversed. This should be corrected to match the intended database types.
| if (thing.db === 'typeDB') { | |
| if (thing.db === 'surrealDB') { |
This issue also applies to the corresponding else-if block for typeDB on line 104.
Summary:
Introduced a new SurrealDB adapter with 'edges' and 'refs' link modes, updating scripts, configurations, and tests to support these modes.
Key points:
linkModesupport inSurrealDBadapter (src/adapters/surrealDB/enrichSchema/helpers.ts,src/helpers.ts)package.jsonscripts for newSurrealDBlink modescross-envdependency inpackage.jsonlogger.tsfor custom loggingqueryMachineto handlesurrealDBRefs(src/stateMachine/query/queryMachine.ts)surql-refs(src/stateMachine/query/surql-refs/*)tests/bench.shandtests/test.shto handle new link modesSurrealDBlink modes (tests/adapters/surrealDB/mocks/*)tests/unit/*)tests/helpers/init.tsandtests/helpers/setup.tsfor new configurationsGenerated with ❤️ by ellipsis.dev