FIX: QRCOde was not rendering on Android#7877
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue causing the QR code to not render on Android by removing the layout animation configuration that was potentially interfering with the rendering process.
- Removed Android-specific layout animation enabling via UIManager.
- Eliminated the useEffect hook triggering LayoutAnimation on prop changes.
Comments suppressed due to low confidence (1)
components/QRCodeComponent.tsx:10
- [nitpick] The removal of the UIManager layout animation enabling and the corresponding useEffect hook is clear, but adding a comment explaining why these changes were made to fix the Android QR code rendering issue could help future maintainers.
if (Platform.OS === 'android' && UIManager.setLayoutAnimationEnabledExperimental) {
Overtorment
approved these changes
May 11, 2025
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
Member
|
weird that its merged.
|
Member
|
im inclined to believe glados. before the merge i manually restarted failed checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.