Thanks to visit codestin.com
Credit goes to github.com

Skip to content

REF: extract BlueLoading from BlueComponents.js#7912

Merged
Overtorment merged 4 commits into
BlueWallet:masterfrom
danilobatson:ref/7911-move-blue-loading-to-own-file
Jun 10, 2025
Merged

REF: extract BlueLoading from BlueComponents.js#7912
Overtorment merged 4 commits into
BlueWallet:masterfrom
danilobatson:ref/7911-move-blue-loading-to-own-file

Conversation

@danilobatson

Copy link
Copy Markdown
Contributor

Closes #7911

Summary

This PR refactors the BlueLoading component by extracting it from BlueComponents.js into its own dedicated file (BlueLoading.tsx).

Changes

  • Removed BlueLoading from BlueComponents.js
  • Created a new BlueLoading.tsx file
  • In the spirit of keeping the commit small. Imports BlueLoading into BlueComponents.js where it is then exported for relevant files

Type of Change

  • Refactor (code change that does not affect external behavior)

Checklist

  • Code compiles without errors
  • All tests pass

Comment thread BlueComponents.js Outdated
@danilobatson danilobatson requested a review from ojokne May 31, 2025 18:05
Comment thread components/BlueLoading.tsx Outdated
@danilobatson danilobatson requested a review from limpbrains June 1, 2025 02:57

@ojokne ojokne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments appear to be resolved. I’ve tested the changes locally, and everything is working as intended. Looks good from my side.

@danilobatson

Copy link
Copy Markdown
Contributor Author

@limpbrains can I get an assist on getting this merged? Have the two review approvals.

@marcosrdz marcosrdz requested a review from Overtorment June 3, 2025 01:05
@GladosBlueWallet

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

@Overtorment Overtorment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Overtorment Overtorment merged commit ab1bbc1 into BlueWallet:master Jun 10, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move BlueLoading from BlueComponents.js to Its Own File

5 participants