OPS: Upgrade RN to 78#7931
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@marcosrdz is that the one where you require my assistance on e2e tests..? |
Yup |
|
detox was failing probably because detox released support for 78 only now: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
✅ Build 7.2.0 (1754680454) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1754828211) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1754899932) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1754899779) has been uploaded to TestFlight and will be available for testing soon. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
✅ Build 7.2.1 (1754996988) has been uploaded to TestFlight and will be available for testing soon. |
|
@marcosrdz can you review my changes pls? |
|
@marcosrdz ios build failed |
At some point RN 78 was reverted back to 77 @Overtorment |
|
apparently, i accidently reverted RN to 77 when i wasresolving conflict, in commit a7d5a0f |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| // FIXME: next line should be removed when https://github.com/wix/Detox/issues/4678 is fixed | ||
| kotlinOptions.freeCompilerArgs += ["-Xopt-in=kotlin.ExperimentalStdlibApi"] |
There was a problem hiding this comment.
cool, looks like not released yet
| const onDonePressed = () => { | ||
| // @ts-ignore idk | ||
| navigation?.getParent().pop(); | ||
| }; |
There was a problem hiding this comment.
Bug: Navigation Regression: Success Screen Button Behavior
The "Done" button on the success screen now only pops one level, a regression from the previous customizable callback that allowed navigation to the root. The navigation?.getParent().pop() call uses a @ts-ignore, indicating a potential type safety issue or incorrect navigation API usage.
No description provided.