REF: Replace TouchableOpacity with Pressable ( part 1 )#7945
Merged
marcosrdz merged 6 commits intoJun 18, 2025
Merged
Conversation
marcosrdz
requested changes
Jun 12, 2025
696e848 to
51d3950
Compare
Member
Author
|
I have removed the inline styles and moved the android ripple color to themes files. Let me know if anything else is needed — ready for re-review |
marcosrdz
approved these changes
Jun 16, 2025
Member
|
conflicts |
Member
|
@marcosrdz if its good, merge it..? |
Member
|
@ojokne please solve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR begins the migration from TouchableOpacity to Pressable, as discussed #2144 (comment). Additional PRs will follow to complete the migration
Changes included
Replaced TouchableOpacity with Pressable in:
BlueComponents.jsscreen/settings/About.tsxscreen/settings/IsItMyAddress.tsxImplementation notes:
Buttons with background:
Applied
android_ripplefeedback on Android (color: "#ccc").Applied
opacity: 0.6on iOS when pressed.Text-only pressables:
opacity: 0.6on both platforms for a consistent visual press effect.This is a scoped update to a few files to verify if the implementation meets expectations.
Happy to iterate based on feedback before continuing with the broader migration.
Related to: #2144