Replace cryptographic functions with noble hashes#7988
Merged
GladosBlueWallet merged 3 commits intoJul 7, 2025
Merged
Conversation
Co-authored-by: overtorment <[email protected]>
Co-authored-by: overtorment <[email protected]>
…dling Co-authored-by: overtorment <[email protected]>
Collaborator
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
limpbrains
approved these changes
Jul 7, 2025
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
createHashandcreateHmacwith@noble/hashesinclass/lnurl.tsfor modern cryptography and a simplified HMAC implementation.The stream-based
createHmacusage was replaced with a synchronous call using@noble/hashes/hmacfor a cleaner and more direct approach.