ADD: add Egyptian Pound (EGP) support using yadioConverter#8076
Merged
Conversation
- Added EGP entry to fiatUnits.json in both android and models directories - Configured with proper ISO code, locale (ar-EG), symbol (ج.م.), and country - Updated source to use yadioConverter since Kraken does not support EGP
limpbrains
approved these changes
Sep 9, 2025
marcosrdz
approved these changes
Sep 12, 2025
limpbrains
approved these changes
Sep 13, 2025
Collaborator
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz |
Collaborator
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment |
Contributor
Author
|
I can tell the issues seem related to the workflow configuration and branch setup rather than the changes in this PR. Since I didn’t want to update the workflow files or branch naming on the upstream without guidance, I held off on making those changes. I’m happy to help adjust things on my side if needed, so please let me know how I can support getting this passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for the Egyptian Pound (EGP) as a fiat currency across Android, iOS, and shared models.
Changes
fiatUnits.json (Android & models):
EGPentry with ISO code, locale (ar-EG), symbol (ج.م.), and country.FiatUnitEnum (iOS):
EGPcase with sourceYadioConvert."Egypt (Egyptian Pound)".Closes #8077