Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the unlock password user experience to replace modal prompts with a more intuitive inline password input interface. The changes improve the UI/UX for entering storage decryption passwords by introducing a custom PasswordInput component with visual feedback animations.
- Creates a new PasswordInput component with shake animations for errors and success feedback
- Updates UnlockWith screen to use the new inline password input instead of modal dialogs
- Modifies startAndDecrypt function to support callback-based password prompts
- Updates e2e tests to use the new password input test ID
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| components/PasswordInput.tsx | New component providing password input with visual feedback animations |
| screen/UnlockWith.tsx | Updated to integrate PasswordInput component and handle password flow |
| blue_modules/start-and-decrypt.ts | Modified to support callback-based password prompting |
| tests/e2e/bluewallet.spec.js | Updated test selectors to use new PasswordInput component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| passwordInputRef.current?.showError(); | ||
| dispatch({ type: SET_IS_AUTHENTICATING, payload: false }); | ||
| isUnlockingWallets.current = false; | ||
|
|
There was a problem hiding this comment.
Trailing whitespace should be removed.
| showSuccess: () => { | ||
| triggerHapticFeedback(HapticFeedbackTypes.NotificationSuccess); | ||
| setIsSuccess(true); | ||
|
|
There was a problem hiding this comment.
Trailing whitespace should be removed.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
ojokne
left a comment
There was a problem hiding this comment.
Run the code on my physical device, everything worked as expected
LGTM
Overtorment
left a comment
There was a problem hiding this comment.
LGTM.
want to test it on testflight now
|
@cursoragent review pls |
Review
export const startAndDecrypt = async (retry?: boolean, passwordPrompt?: PasswordPromptCallback): Promise<boolean> => {
// If wallets are already loaded, no need to migrate, decrypt, or load from disk.
Learn more about Cursor Agents |
|
✅ Build 7.2.1 (1760609991) has been uploaded to TestFlight and will be available for testing soon. |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
|
✅ Build 7.2.1 (1760812247) has been uploaded to TestFlight and will be available for testing soon. |
No description provided.