refactor: speed-up getting utxo (improves send screen performance)#8138
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
4198626 to
c943aba
Compare
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDerivedUtxoFromOurTransaction()was calling.getTransactions()in cycle, which is a heavy operation. simply caching resolved performance issues on midsize-large walletsNote
Cache
getTransactions()when deriving UTXOs and add aMeasureutility to timegetUtxoin SendDetails, improving send screen performance.getTransactions()result ingetDerivedUtxoFromOurTransaction()to avoid repeated calls when filtering spent UTXOs in:class/wallets/abstract-hd-electrum-wallet.tsclass/wallets/legacy-wallet.tsscreen/send/SendDetails.tsxfee recalculation via newMeasure('getUtxo').class/measure.tssimple timing helper.Written by Cursor Bugbot for commit c943aba. This will update automatically on new commits. Configure here.