ADD: lightning wallet powered by ark#8142
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1e64985 to
a126b76
Compare
|
✅ Build 7.2.1 (1761331224) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1761331338) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762869263) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762870401) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762871160) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762872823) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1762875919) has been uploaded to TestFlight and will be available for testing soon. |
|
Cursor Agent can help with this pull request. Just |
There was a problem hiding this comment.
Bug: Assertion Failure: Data Uninitialized
The test asserts that l1.info_raw is truthy, but the fetchInfo() method call was removed from the test. Since info_raw is initialized to false in the LightningCustodianWallet class and is never populated without calling fetchInfo(), this assertion will always fail.
tests/integration/lightning-custodian-wallet.test.js#L50-L51
BlueWallet/tests/integration/lightning-custodian-wallet.test.js
Lines 50 to 51 in 539b8b1
|
✅ Build 7.2.1 (1763047984) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763053281) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763062800) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763067234) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763070343) has been uploaded to TestFlight and will be available for testing soon. |
| async addInvoice(amt: number, memo: string) { | ||
| if (!this._wallet) await this.init(); | ||
| assert(this._arkadeLightning, 'Ark Lightning not initialized'); | ||
| assert(amt > 333, 'Only invoices > 333 sat allowed'); |
There was a problem hiding this comment.
You should use limits.minimal from https://api.ark.boltz.exchange/v2/swap/submarine instead of hard coding 333.
Additionally, you should test if amt < limits.maximal (that you get from the same endpoint)
limpbrains
left a comment
There was a problem hiding this comment.
Show better error when trying to pay < 333
|
✅ Build 7.2.1 (1763123747) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763126747) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763126571) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.1 (1763133237) has been uploaded to TestFlight and will be available for testing soon. |
limpbrains
left a comment
There was a problem hiding this comment.
I made a refill using an external address and sent the funds. The wallet showed a “Pending refill” status but provided no confirmation target or any additional information about what would happen next.
I tried tapping on it, but nothing happened.
When the transaction was confirmed, BlueWallet still didn’t update.
Only after restarting the app did it finalize the refill.
Overall, the procedure isn’t very clear.
It would be helpful to have a detailed status screen explaining what’s going on, along with a button to manually refresh or proceed.
Other than that, everything works fine.
Note
Adds a new Ark-powered Lightning wallet (arkade://) with swaps, UI integration, import flow, and supporting infra/config/tests; also removes the legacy LN additional info screen and refactors wallet selection/navigation.
LightningArkWallet(class/wallets/lightning-ark-wallet.ts): Arkade + Boltz swap integration (generate/importarkade://, balance/tx fetch, invoice create/pay, boarding UTXOs, Ark address).blue-app.ts,types.ts,index.ts,wallet-import.ts).LightningArkWalletlike Lightning for gradients/images and Manage Funds (wallet-gradient.ts,TransactionsNavigationHeader.tsx,WalletsCarousel.tsx).screen/wallets/Add.tsx,components/WalletButton.tsx).screen/wallets/WalletDetails.tsx).select-walletto accept navigation object; update callers.@arkade-os/sdkand@arkade-os/boltz-swapdeps; Metro aliases (expo/fetchshim, Ark adapter), Jest transform ignore updates;shim.jsupdate; fetch timeout 20s.Written by Cursor Bugbot for commit 1d4f557. This will update automatically on new commits. Configure here.