REF: Replace TouchableOpacity with Pressable#8147
Conversation
There was a problem hiding this comment.
The StyledButton component doesn't seem to be used anywhere in the code base, Can this be removed?
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
limpbrains
left a comment
There was a problem hiding this comment.
I’m sorry, but I don’t see the value in this PR.
As far as I know, there are currently no issues with TouchableOpacity, and RN isn’t planning to deprecate it anytime soon. While Pressable is indeed more advanced, our goal is to have the component behave like TouchableOpacity, so switching doesn’t seem necessary at the moment.
Thanks for your review, if that's the case then this PR can be closed |
This PR is a continuation from #7965 to replace
TouchableOpacitywithPressableRelated to issue #2144