Thanks to visit codestin.com
Credit goes to github.com

Skip to content

REF: replace buffer with Uint8Array#8158

Merged
Overtorment merged 2 commits into
masterfrom
remove-buffer
Dec 5, 2025
Merged

REF: replace buffer with Uint8Array#8158
Overtorment merged 2 commits into
masterfrom
remove-buffer

Conversation

@ojokne

@ojokne ojokne commented Nov 12, 2025

Copy link
Copy Markdown
Member

This PR continues replacing buffer with Uint8Array

@ojokne

ojokne commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

@ojokne

ojokne commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

@Overtorment could you advice here

@limpbrains

Copy link
Copy Markdown
Collaborator

@limpbrains should the use of buffer in the tests and blue_modules also be migrated to uint8Array

In the blue_modules - most definetly
In the tests - lowest priority

@Overtorment

Copy link
Copy Markdown
Member

in blue_modules some modules are actually dependencies that are copied from upstream, so they are not pulled from npm (usually because the developer is untrusted or to fix some issues). migrating it would be a wasted effort as it will be replaced in next update (pull from upstream)

@Overtorment

Copy link
Copy Markdown
Member

in tests - yeah, low priority, tests run in nodejs where Buffer is native

@Overtorment Overtorment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ojokne ojokne marked this pull request as ready for review November 27, 2025 14:13
@ojokne ojokne removed the WIP label Nov 27, 2025
@GladosBlueWallet

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz

@Overtorment Overtorment merged commit 01092cd into master Dec 5, 2025
13 of 14 checks passed
@Overtorment Overtorment deleted the remove-buffer branch December 5, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants