Thanks to visit codestin.com
Credit goes to github.com

Skip to content

REF: bump bip32 and migrate buffers#8177

Merged
GladosBlueWallet merged 1 commit into
masterfrom
ref-bip32
Nov 21, 2025
Merged

REF: bump bip32 and migrate buffers#8177
GladosBlueWallet merged 1 commit into
masterfrom
ref-bip32

Conversation

@Overtorment

@Overtorment Overtorment commented Nov 20, 2025

Copy link
Copy Markdown
Member

Note

Upgrade bip32 to v5 and migrate Buffer-based wallet APIs/tests to Uint8Array, with supporting ECC and utility updates.

  • Dependencies:
    • Upgrade bip32 from 3.x to 5.0.0 (lockfile updated; new sub-deps added).
  • Core changes (Buffer → Uint8Array):
    • Wallet APIs now return/accept Uint8Array (e.g., _getNodePubkeyByIndex, _getPubkeyByAddress).
    • Replace Buffer hex conversions with helpers like uint8ArrayToHex; update getIdentityPubkey to return hex from Uint8Array.
    • Multisig: replace Buffer.compare with compareUint8Arrays in sortBuffers.
  • ECC Integration:
    • Update TinySecp256k1Interface import for bip32 compatibility in noble_ecc.
  • Tests:
    • Adjust expectations to use Uint8Array and uint8ArrayToHex; update PSBT derivation pubkey assertions accordingly.

Written by Cursor Bugbot for commit 476ec19. This will update automatically on new commits. Configure here.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​bip32@​5.0.01001008287100

View full report

@ojokne ojokne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GladosBlueWallet GladosBlueWallet merged commit 67ef9c2 into master Nov 21, 2025
15 checks passed
@GladosBlueWallet

Copy link
Copy Markdown
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

@GladosBlueWallet GladosBlueWallet deleted the ref-bip32 branch November 21, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants