REF: bump bitcoinjs and silent-payments#8179
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz |
| if (k) this._map.set(k.toLowerCase(), v); | ||
| } | ||
| }); | ||
| } else if (typeof init === 'object' && init !== null) { |
| function normalizeHeaders(h) { | ||
| const out = {}; | ||
| if (!h) return out; | ||
| if (typeof h === 'object' && h !== null) { |
| } else { | ||
| // Fallback: JSON | ||
| const jsonBody = JSON.stringify(body); | ||
| if (!headers['content-type']) { |
There was a problem hiding this comment.
Bug: Case-sensitive content-type header check fails
The check !headers['content-type'] uses lowercase but normalizeHeaders preserves the original header casing. If a caller provides Content-Type with different casing, the check incorrectly evaluates as false, potentially adding a duplicate header or missing the existing one. This causes inconsistent behavior when JSON bodies are sent with custom header casing.
limpbrains
approved these changes
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Upgrades bitcoinjs-lib and related deps, adds a Node.js expo/fetch polyfill used in Jest, and simplifies VtxoManager initialization.
bitcoinjs-libto7.0.0,silent-paymentsto latest,@arkade-os/boltz-swapto0.2.9,@arkade-os/sdkto0.3.7, andtypescriptto^5.9.3.expo/fetchto new Node.js polyfillutil/expo-fetch-nodejs.jsinjest.config.js.util/expo-fetch-nodejs.jsproviding streaming, AbortController, and header handling.thresholdPercentageoption when creatingVtxoManagerinclass/wallets/lightning-ark-wallet.ts.Written by Cursor Bugbot for commit 36a243c. This will update automatically on new commits. Configure here.