Refactor ark lightning#8185
Merged
Merged
Conversation
Collaborator
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
limpbrains
approved these changes
Nov 25, 2025
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds decode cache and invoice-expiry helper to Lightning wallet, parallelizes Ark VHTLC claiming, and tidies transaction construction.
class/wallets/lightning-custodian-wallet.ts:decodeInvoiceresults in_staticDecodedInvoiceCache.isInvoiceExpired(invoice, currentTimestamp?)utility.class/wallets/lightning-ark-wallet.ts:getTransactions()to reusewalletID.Promise.all; improve logging and avoid repeated property access.tests/integration/lightning-ark-wallet.test.ts: Add test forisInvoiceExpiredbehavior.Written by Cursor Bugbot for commit f0edc10. This will update automatically on new commits. Configure here.