Improve e2e test DX: cleaner stack traces & robust emulator setup#8305
Merged
Conversation
Overtorment
approved these changes
Feb 26, 2026
Collaborator
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite
detox-prepare-android-emu.sh— The old script was a fragile 4-liner with hardcoded paths and API level. The new version auto-detects ARM vs x86 arch, readsapi-levelfrom.github/workflows/e2e.ymlso it stays in sync with CI, supports bothcmdline-tools/latestand legacytools/binSDK layouts, and enables hardware keyboard to match CI config.e2e helpers: rewrite error stacks to point at spec files — When a Detox assertion fails inside a helper (
waitForId,waitForText,tapAndTapAgain*), the stack trace now shows the calling spec line instead of helperz.js internals. UsesError.captureStackTraceto capture the call site and rewrites the stack on rethrow.Before
After: