Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: Icon alignment#8360

Merged
marcosrdz merged 1 commit into
masterfrom
iconalig
Mar 3, 2026
Merged

FIX: Icon alignment#8360
marcosrdz merged 1 commit into
masterfrom
iconalig

Conversation

@marcosrdz

Copy link
Copy Markdown
Member

No description provided.

@marcosrdz marcosrdz self-assigned this Mar 2, 2026
@marcosrdz marcosrdz requested a review from Overtorment March 2, 2026 16:29

@GladosBlueWallet GladosBlueWallet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated test-chamber scan results: a few sharp edges.

paddingLeft: 12,

paddingRight: 12,
}),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the explicit left/right padding from the container style. If callers don’t consistently pass padding via style, this will silently change spacing and touch target feel for every row. If the goal is alignment, consider moving padding to the parent list item wrapper or a dedicated inner container so layout intent is unambiguous.

Comment thread ios/Podfile.lock
PODS:
- boost (1.84.0)
- BugsnagReactNative (8.4.0):
- BugsnagReactNative (8.8.1):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podfile.lock now bumps BugsnagReactNative to 8.8.1. If this PR is supposed to be “icon alignment”, this is dependency drift disguised as UI. Please confirm it’s intentional (and not a local pod update accident), otherwise revert the lockfile churn.

Comment thread ios/Podfile.lock
PODFILE CHECKSUM: eb430c3fd96af23d4962c4c041798d65efc6843e

COCOAPODS: 1.16.2
COCOAPODS: 1.15.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfile COCOAPODS version changed to 1.15.2. Downgrading the generator version tends to create endless diffs across machines/CI. Make sure the repo actually standardizes on 1.15.2; if not, regenerate with the expected CocoaPods version and keep this stable.

@Overtorment Overtorment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcosrdz marcosrdz merged commit 50e4e3a into master Mar 3, 2026
13 checks passed
@marcosrdz marcosrdz deleted the iconalig branch March 3, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants