Conversation
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Test chamber report: two changes entered, one may escape with missing icons.
| @@ -205,7 +205,6 @@ | |||
| <string>Ionicons.ttf</string> | |||
There was a problem hiding this comment.
You removed Octicons.ttf from UIAppFonts. If anything still imports react-native-vector-icons/Octicons, iOS will happily render nothing (or crash in weird ways). Please confirm Octicons are no longer referenced, or keep the font registered.
|
|
||
| const renderRow = useCallback( | ||
| ({ item }: { item: Address }) => { | ||
| const { key, ...rest } = item; |
There was a problem hiding this comment.
const { key, ...rest } = item; assumes item.key is always present and stable. If this ever comes from derived data, consider hardening (e.g., String(item.key ?? item.address)), or you’ll get re-render churn.
| const { key, ...rest } = item; | ||
| return ( | ||
| <AddressItem item={item} {...item} balanceUnit={balanceUnit} walletID={walletID} allowSignVerifyMessage={allowSignVerifyMessage} /> | ||
| <AddressItem key={key} item={item} {...rest} balanceUnit={balanceUnit} walletID={walletID} allowSignVerifyMessage={allowSignVerifyMessage} /> |
There was a problem hiding this comment.
FlatList already has keyExtractor={item => item.key}. Passing key={key} to AddressItem is redundant and can mask key issues during refactors. Let FlatList own the key unless there’s a specific reason.
| const { key, ...rest } = item; | ||
| return ( | ||
| <AddressItem item={item} {...item} balanceUnit={balanceUnit} walletID={walletID} allowSignVerifyMessage={allowSignVerifyMessage} /> | ||
| <AddressItem key={key} item={item} {...rest} balanceUnit={balanceUnit} walletID={walletID} allowSignVerifyMessage={allowSignVerifyMessage} /> |
There was a problem hiding this comment.
You pass both item={item} and spread ...rest (the same fields). That’s two sources of truth; if AddressItem derives from one but consumers use the other, you can get inconsistent props. Pick one interface (either item or explicit props).
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment |
No description provided.