REL: bump to 8.0.0#8444
Conversation
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz |
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Automated review chamber report: this release bump still has a couple of platform-specific ways to disappoint the deployment pipeline.
| @@ -87,7 +87,7 @@ android { | |||
| minSdkVersion rootProject.ext.minSdkVersion | |||
| targetSdkVersion rootProject.ext.targetSdkVersion | |||
| versionCode 1 | |||
There was a problem hiding this comment.
Android release bookkeeping is still pinned to versionCode 1. Charming. Bumping only versionName means Google Play sees no monotonically increasing build number, so a new upload can be rejected or fail to upgrade cleanly over an existing release. This needs a fresh versionCode for 8.0.0 as well.
| "$(inherited)", | ||
| ); | ||
| MARKETING_VERSION = 7.2.7; | ||
| MARKETING_VERSION = 8.0.0; |
There was a problem hiding this comment.
Only MARKETING_VERSION changed here; the adjacent CURRENT_PROJECT_VERSION stayed the same. That leaves the iOS/macOS build number unchanged, which is exactly the sort of detail App Store Connect/TestFlight likes to punish with duplicate-build-number rejections on the next submission.
Note
Low Risk
Low risk: this is a version/marketing bump only, with no functional code changes. Main risk is release metadata inconsistencies if other platform/version references exist elsewhere.
Overview
Bumps the app version from
7.2.7to8.0.0across release metadata.Updates Android
versionName, iOSMARKETING_VERSION(app + extensions/widgets/watch), and the npmpackage.json/package-lock.jsonversion fields to keep platform builds in sync.Written by Cursor Bugbot for commit 6732265. This will update automatically on new commits. Configure here.