fix: new loading icons #8496
Conversation
GladosBlueWallet
left a comment
There was a problem hiding this comment.
Automated review: removing spinners is fine, removing user feedback is less fine.
| return <ActivityIndicator />; | ||
| } | ||
|
|
||
| if (state.showPasswordInput) { |
There was a problem hiding this comment.
The ActivityIndicator for (isAuthenticating && !showPasswordInput) was removed. If biometrics takes a moment, this can look like a frozen screen (especially if buttons are also disabled). Suggest keeping a lightweight “Authenticating…” indicator, or at least leaving some visible state change during auth.
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains |
|
Wake the fuck up samurai, we have PRs to merge
[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment |
There was a problem hiding this comment.
i dropped it into tinypng.com and got 266 kb with no visual degradation
Overtorment
left a comment
There was a problem hiding this comment.
all yuuuuuuuuuge pngs needs a bit of compression/optimization
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
No description provided.