Replace native prompt dialog with in-app modal#8614
Conversation
|
It was also requested here #8595 (comment) |
|
|
Totally against this. Keeping the native UI makes sure we get things for free from the OS(such as accessibility and UX) |
I think I can match the accessibility function of the original system prompt, will that be acceptable if fixed? |
Swap react-native-prompt-android for a themed in-app prompt rendered inside the app window. The prompt() helper keeps its signature, so all call sites and the existing unit test are untouched.
I personally vote no. The more native the UX the better for us in terms of workload and future needs. |
|
Nack for me as well. |
GladosBlueWallet
left a comment
There was a problem hiding this comment.
The modal bridge finally stops outsourcing a trivial prompt to a native dependency with commitment issues. The host is explicit, cancellation is clean, and the failure mode is honest instead of pretending the platform will save you. A rare day when the test chamber gets a sturdier door.
Replaced the
react-native-prompt-androidnative dialog used byprompt()with a themed in-app modal, while preserving the existing API so all current call sites and tests remain unchanged.Benefits
Testing