REF: Prompt Modal with useReducer and tests#8622
Open
marcosrdz wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors PromptPasswordConfirmationSheet to use a useReducer-based state model and introduces unit tests to cover key UI flows and reducer behavior.
Changes:
- Refactor
PromptPasswordConfirmationSheetstate management from multipleuseStatecalls to a dedicated reducer (PromptPasswordConfirmationSheet.reducer.ts). - Add unit tests covering modal flows (enter/create password, fake storage) and reducer behavior.
- Adjust the navigation stack options for the prompt sheet (notably removing the header title).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| screen/PromptPasswordConfirmationSheet.tsx | Refactors state handling to useReducer, extracts shake logic, and adds an alert path for password mismatch. |
| screen/PromptPasswordConfirmationSheet.reducer.ts | New reducer module defining state/actions and resettable initial state. |
| tests/unit/PromptPasswordConfirmationSheet.test.tsx | New UI-oriented unit tests for the sheet, including navigation/storage/haptics mocks. |
| tests/unit/prompt-password-confirmation-reducer.test.ts | New unit tests validating reducer transitions and initial state behavior. |
| navigation/PromptPasswordConfirmationStack.tsx | Updates stack screen options; currently removes the localized title. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+136
to
+139
| if (isCreateFlow && password && confirmPassword && password !== confirmPassword) { | ||
| failWithShake(); | ||
| presentAlert({ message: loc.settings.passwords_do_not_match }); | ||
| return; |
Comment on lines
19
to
20
| options={navigationStyle({ | ||
| title: loc.settings.password, | ||
| presentation: 'formSheet', |
Comment on lines
+208
to
+211
|
|
||
| it('rejects CREATE_FAKE_STORAGE when password is already in use', async () => { | ||
| setRoute({ modalType: MODAL_TYPES.CREATE_FAKE_STORAGE, returnTo: 'PlausibleDeniability' }); | ||
| mockIsPasswordInUse.mockResolvedValue(true); |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
GladosBlueWallet
approved these changes
Jun 7, 2026
GladosBlueWallet
left a comment
Collaborator
There was a problem hiding this comment.
The sheet's state machine is much less fragile now, and the tests cover the actual transitions instead of worshipping a mock altar. The shake/error paths remain intact, the create/encrypt flows are cleaner, and the reducer makes the whole thing less haunted. Another small miracle: the code now remembers what state it is in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.