Pull request overview

This PR refactors navigation header controls to prefer native iOS 26 unstable_header*Items (UIBarButtonItem-backed) for close/menu buttons, and introduces a helper to map existing Action definitions into native menu items.

Changes:

• Add unstable_headerLeftItems / unstable_headerRightItems close button support to navigationStyle.
• Introduce mapActionsToNativeHeaderMenuItems to convert Action[] into native-stack header menu item definitions.
• Update AddWalletStack and DetailViewScreensStack to use native header menus for actions (ellipsis menu) and extracted options builders.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

I've tried, easy to reproduce

navigation/AddWalletStack.tsx:191 — Native wallet-type menu desyncs from screen state; picking a type in the native menu silently creates the wrong wallet. Menu reads/writes route.params.selectedIndex/selectedWalletType, but screen/wallets/Add.tsx keeps selection in a local reducer, never reads those params (Add.tsx:123 destructures only entropy/words), and createWallet branches on reducer state (Add.tsx:340). iOS 26 user picks Taproot/Legacy/Lightning in the header menu → params update, screen doesn't → Create builds default SegWit wallet. Reverse too: on-screen selector never updates the native checkmark. Also, unstable_headerRightItems is set unconditionally here, while DetailViewScreensStack gates on isIOS26OrHigher.

other issues Claude complained but I did not check

2. navigation/DetailViewScreensStack.tsx:669 — BIP47 "Payments Code" header menu is dead on ALL platforms; toggle unreachable. showBip47Menu gates on route.params.allowBIP47 && isBIP47Enabled — nothing in the repo ever sets those params (nor are they in the param list types), so it's permanently false. toggleBIP47RequestedAt (:673) is written but read nowhere. And the screen's own setParams({ headerRight: renderHeaderRightMenu }) (ReceiveDetails.tsx:367-382) is now ignored because withRouteParamHeaderOptions was dropped from this route — so the JS-path menu is gone too. Sub-issue: ignored headerBackVisible: false param may resurface a duplicate back button on Android.
3. screen/send/SendDetails.tsx:1214 — headerRightActions().flat() collapses menu groups on the native path. headerRightActions returns Action[][] (5 sections); the JS iOS path preserves group separators via synthetic inline parents (TooltipMenu.helpers.ts:60-79), but flat() yields one undivided native list. Native API supports inline submenus (inline: true) — map each sub-array to an inline group instead of flattening.
4. screen/send/SendDetails.tsx:1213 — duplicate full actions build per keystroke. New useMemo calls headerRightActions() in addition to HeaderRight's own call; wallet.getBalance(), howManySignaturesCanWeMake(), allowCosignPsbt() etc. now run ~2× per change, and addresses gets a new identity per amount keystroke, so this fires while typing (the setOptions churn itself is pre-existing). Build the actions array once in a memo and feed both renderers.
5. navigation/AddWalletStack.tsx:239 — ellipsis-menu envelope copy-pasted 4×. Identical {type:'menu', label: loc.wallets.details_options, icon: ellipsis, menu:{...}} + parallel JS HeaderMenuButton pair at AddWalletStack ×2, DetailViewScreensStack :688 (already drifted — omits identifier), SendDetails :1221. One helper returning { headerRight, unstable_headerRightItems } from a single Action[] kills all four.
6. (weak, take or leave) components/nativeHeaderMenuItems.ts:29 — parallel Action-tree traversal alongside TooltipMenu.helpers.ts mapLeaf/buildMenu. Verified as real surface duplication, but target types genuinely differ (tri-state 'mixed' preserved here vs collapsed there; either/or submenu shape) — sharing is a non-trivial refactor, defensible to decline.