feat: bip39 suggestions on import#8741
Draft
ncoelho wants to merge 4 commits into
Draft
Conversation
|
✅ Build 8.0.1 (1783247031) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 8.0.1 (1783252154) has been uploaded to TestFlight and will be available for testing soon. |
Collaborator
|
Just some thoughts: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bip39 suggestions on import. Suggest the possible words based on the typed character, using the keyboard helper. This helper was only available for iOS, tried to made it work on android, but android measures are unreliable.
Note: seems complex to align a custom bar on android on top of the keyboard without an external lib. Had to hardcode the measure to get it align for this specific device, may not work on others. Any suggestion welcome.