REF: Auth Flow#8750
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Refactors the app authentication/unlock flow so the navigation tree is only mounted after wallets are initialized/unlocked, and wires keychain-wipe handling into the unlock/decrypt path. Also upgrades React Native to 0.86.0 and updates related iOS/JS lockfiles and some navigation package versions.
Changes:
- Move the unlock gate from the navigator into
App.tsx, buffering deep links until after unlock. - Extend
startAndDecrypt/ biometrics keychain-wipe alert to accept a callback and relock the app on wipe. - Upgrade React Native (0.85.3 → 0.86.0) and update associated lockfiles; adjust React Navigation dependency versions.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| screen/UnlockWith.tsx | Passes relock callback into startAndDecrypt and updates hook deps. |
| blue_modules/start-and-decrypt.ts | Adds onKeychainWipe callback support when showing wipe alert. |
| hooks/useBiometrics.ts | Removes navigation reset; adds wipe callback support and relock behavior. |
| NavigationService.ts | Removes reset() helper. |
| navigation/index.tsx | Removes UnlockWithScreen from the stack; always renders DrawerRoot. |
| navigation/DetailViewStackParamList.ts | Removes UnlockWithScreen route type. |
| App.tsx | Introduces AppContent gating nav mount on walletsInitialized and deep link buffering. |
| package.json | Upgrades RN and adjusts React Navigation version specs. |
| package-lock.json | Lockfile updates reflecting dependency upgrades. |
| ios/Podfile.lock | CocoaPods lock updates for RN 0.86.0 and related pods. |
| ios/BlueWallet.xcodeproj/project.pbxproj | Adds PODFILE_DIR build setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { useState, useEffect, useCallback } from 'react'; | ||
| import { Alert, Platform } from 'react-native'; | ||
| import ReactNativeBiometrics, { BiometryTypes as RNBiometryTypes } from 'react-native-biometrics'; | ||
| import RNSecureKeyStore, { ACCESSIBLE } from 'react-native-secure-key-store'; | ||
| import loc from '../loc'; |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
No description provided.