Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add option for persistence for every deployment#360

Merged
BorisPolonsky merged 5 commits into
BorisPolonsky:masterfrom
giladd123:additional-volumes
Dec 29, 2025
Merged

Add option for persistence for every deployment#360
BorisPolonsky merged 5 commits into
BorisPolonsky:masterfrom
giladd123:additional-volumes

Conversation

@giladd123
Copy link
Copy Markdown
Contributor

Add the option for persistence for every deployment (in the same format as sandbox-deployment.yaml).

@BorisPolonsky
Copy link
Copy Markdown
Owner

BorisPolonsky commented Dec 25, 2025

We could like to proceed with this idea, and it would be better if values.schema.json got updated too to keep it consistent with sandbox component.

@giladd123
Copy link
Copy Markdown
Contributor Author

I've updated values.schema.json using the losisin/helm-values-schema-json plugin, with --draft 7 and --indent 2. It sorted the values alphabetically. If that's an issue, let me know if there's a preferable way to generate the file.

Comment thread charts/dify/templates/api-deployment.yaml
Comment thread charts/dify/templates/plugin-daemon-deployment.yaml
Copy link
Copy Markdown
Owner

@BorisPolonsky BorisPolonsky Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component api, worker and pluginDaemon features automatic volume and volumeMount (app-data in this case) that doesn't confine to persistence.enabled. The current implementation (adding persistence.enabled) will lead to confusion. In addtion, api and worker are designed to share the same persistence configuration.
or simplicity, we'd advise to

  • opt out the persistence option for worker and leave it as is

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option makes it impossible to mount configMaps/secrets

Copy link
Copy Markdown
Owner

@BorisPolonsky BorisPolonsky Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, we'll see what could be done.

@BorisPolonsky
Copy link
Copy Markdown
Owner

BorisPolonsky commented Dec 26, 2025

We've updated values.schema.json to match the layout of values.yaml thus making git diff more concise. We've also proposed to eliminate possible confusions and keep things simple for existing users as stated above as the long term effort to lower the complexity of this chart for for a long time.

Shall we proceed with the preferable option?

@BorisPolonsky BorisPolonsky added the enhancement New feature or request label Dec 26, 2025
@giladd123
Copy link
Copy Markdown
Contributor Author

Shall we proceed with the preferable option?

The preferable option loses some functionality. I think we can find a better way to implement this

@BorisPolonsky
Copy link
Copy Markdown
Owner

BorisPolonsky commented Dec 29, 2025

OK. Let's set the ultimate goal to "provide unify extra volume mount support for each component".

We'll expect things listed below in the following updates:

  • Enable extra volume and extra volume mount configuration for each of the component. (Achieved already in this PR)
  • Unify naming convention following weaviate-helm and bitnami/redis, we'll use <component>.extraVolumes and <component>.extraVolumeMounts terminology instead instead of <component>.persistence.volumeMounts and <component>.persistence.volumeMount, including the existing sandbox component.
  • Keep <component>.persistence backward compatible and follow conventions in bitnami/charts as much as possible like bitnami/reids

@BorisPolonsky BorisPolonsky merged commit 86e134c into BorisPolonsky:master Dec 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants