refactor: unify frame sharing with Rust Arc, remove FFmpeg ref counting #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors frame data sharing from FFmpeg's reference counting to Rust's Arc<RwLock<Frame>>, providing a unified approach to memory management and eliminating dual reference counting systems.
- Replaces
Frame::try_clone()withFrame::deep_clone()for full copies andFrame::into_shared()for Arc-based sharing - Updates
VideoFrame,AudioData, encoders, andImageDecoderto useArc<RwLock<Frame>>internally - Removes unused
Packet::try_clone()method and Clone trait implementation
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds parking_lot dependency for non-poisoning RwLock with better performance |
| src/codec/frame.rs | Replaces try_clone() with deep_clone() for full copies and adds into_shared() for Arc wrapping |
| src/codec/packet.rs | Removes unused try_clone() method and Clone trait implementation |
| src/webcodecs/video_frame.rs | Refactors to use Arc<RwLock> internally, adds from_internal_arc constructors, updates all frame access to use read locks |
| src/webcodecs/video_encoder.rs | Updates to receive Arc<RwLock> from VideoFrame, uses deep_clone when mutation needed |
| src/webcodecs/audio_data.rs | Refactors to use Arc<RwLock> internally, updates all frame access to use read locks |
| src/webcodecs/audio_encoder.rs | Updates to use deep_clone() instead of try_clone() |
| src/webcodecs/image_decoder.rs | Caches decoded frames as Arc<RwLock> for efficient multi-access |
| index.d.ts | Updates documentation for VideoFrame.clone() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace FFmpeg's internal reference counting (av_frame_clone) with Rust's Arc<RwLock<Frame>> for sharing frame data. This eliminates dual reference counting and provides a single source of truth. Key changes: - Add parking_lot dependency for better RwLock performance - Frame: remove try_clone(), add deep_clone() and into_shared() - Packet: remove try_clone() (0 callers) - VideoFrameInner/AudioDataInner: use Arc<RwLock<Frame>> - VideoEncoder/AudioEncoder: share frames via Arc, deep_clone when mutation needed - ImageDecoder: cache frames as Arc for efficient multi-access 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
641333b to
720f0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace FFmpeg's internal reference counting (av_frame_clone) with Rust's Arc<RwLock> for sharing frame data. This eliminates dual reference counting and provides a single source of truth.
Key changes:
🤖 Generated with Claude Code
Note
Unifies frame ownership by replacing FFmpeg ref-counted clones with Rust
Arc<RwLock<Frame>>, reducing copies and centralizing synchronization.parking_lotand introduceFrame::deep_clone()andFrame::into_shared(); removetry_clone()usage throughoutAudioData/VideoFrameinternals toArc<RwLock<Frame>>;VideoFrame.clone()now shares backing data; exposeframe_arc()and addfrom_internal_arc(_with_color_space)VideoEncoder/AudioEncoderto accept/share frames viaArcand onlydeep_clone()when mutation or upload requires ownership; adjust scaling/copy paths to use read locksImageDecodercaches decoded frames as sharedArcframes and returnsVideoFramevia shared constructorsPacket::try_clone()andCloneimpl (no callers)VideoFrame.clone()sharing semantics inindex.d.tsWritten by Cursor Bugbot for commit 720f0c4. This will update automatically on new commits. Configure here.