Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Event for preparing anvil repairs. Fixes BUKKIT-2850#770

Closed
pruby wants to merge 1 commit into
Bukkit:masterfrom
pruby:anvil_events
Closed

Event for preparing anvil repairs. Fixes BUKKIT-2850#770
pruby wants to merge 1 commit into
Bukkit:masterfrom
pruby:anvil_events

Conversation

@pruby

@pruby pruby commented Feb 15, 2013

Copy link
Copy Markdown

Event to hook in to anvil activity. Allows the item to be created as a result of repair and the exp cost in levels to be changed.

Bukkit/CraftBukkit#1030

@riking

riking commented Feb 15, 2013

Copy link
Copy Markdown
Contributor

Can you git rebase -i and squash these into one?

@pruby

pruby commented Feb 16, 2013

Copy link
Copy Markdown
Author

Squashed in to one commit

@pruby

pruby commented Feb 16, 2013

Copy link
Copy Markdown
Author

Added documentation that result item stack may be null if nothing would normally be produced.

@riking

riking commented Feb 18, 2013

Copy link
Copy Markdown
Contributor

Change the title - this is the event to handle anvils choosing the result.

@pruby

pruby commented Feb 27, 2013

Copy link
Copy Markdown
Author

Documented that this event can be triggered multiple times when an item is placed in the Javadoc. That seems unavoidable as the client sends multiple packets, each triggering that call when an item is initially placed.

@riking

riking commented Feb 28, 2013

Copy link
Copy Markdown
Contributor

Oh yeah, do we have a test plugin to verify that anything changed actually displays right on the client?

@pruby

pruby commented Feb 28, 2013

Copy link
Copy Markdown
Author

My test was tacked on to another plugin I happened to be writing at the time - can pull it out in to a test plugin soon & get back to you.

@riking

riking commented Feb 28, 2013

Copy link
Copy Markdown
Contributor

Well, I can take your word for it too. Just make sure to test that it shows up on the client.

@pruby

pruby commented Mar 8, 2013

Copy link
Copy Markdown
Author

Sorry, lost track and forgot to respond. Yes, changes here show up on the client.

@ghost ghost assigned riking Mar 19, 2013
@riking

riking commented Mar 21, 2013

Copy link
Copy Markdown
Contributor

@gmcferrin added it to description, it seems he linked this one from the CB but not the other way around

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excess whitespace

@gmcferrin

Copy link
Copy Markdown
Contributor

From @amaranth:

We wouldn't want to change the cost without that showing on the client so this just becomes a named replacement for InventoryClickEvent that erroneously gets called 3 times

Unless this is no longer true, we see no reason to pull this.

@gmcferrin gmcferrin closed this Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants