Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Fix the null pointer error issue when deleting a code block #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathisFederico merged 1 commit into from
Oct 28, 2021
Merged

🐛 Fix the null pointer error issue when deleting a code block #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opencodeblocks/graphics/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from PyQt5.QtCore import QEvent, QPointF, Qt
from PyQt5.QtGui import QMouseEvent, QPainter, QWheelEvent
from PyQt5.QtWidgets import QGraphicsView
from sip import isdeleted

from opencodeblocks.graphics.scene import OCBScene
from opencodeblocks.graphics.socket import OCBSocket
Expand Down Expand Up @@ -142,7 +143,6 @@ def deleteSelected(self):

def bring_forward(self, event: QMouseEvent):
""" When a codeblock is selected, it will be drawn in front of other blocks """
scene = self.scene()
item_at_click = self.itemAt(event.pos())
if item_at_click is None:
return event
Expand All @@ -153,7 +153,7 @@ def bring_forward(self, event: QMouseEvent):
item_at_click = item_at_click.parentItem()

if isinstance(item_at_click, OCBBlock):
if self.currentSelectedBlock is not None:
if self.currentSelectedBlock is not None and not isdeleted(self.currentSelectedBlock):
self.currentSelectedBlock.setZValue(0)
item_at_click.setZValue(1)
self.currentSelectedBlock = item_at_click
Expand Down