🪲 Deal with ipynb of different format #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisFederico
requested changes
Jan 14, 2022
Member
MathisFederico
left a comment
There was a problem hiding this comment.
Add an integration test to ensure this .ipynb type will be covered.
Maybe we should have a test for each common platform (vscode, colab, jupyterlab, kaggle, ...)
MathisFederico
approved these changes
Jan 15, 2022
Member
MathisFederico
left a comment
There was a problem hiding this comment.
Nice fix !
If this appears again for an other format reason, we will need tests !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213