style: simplify some statements for readability#271
Conversation
hirehamir
left a comment
There was a problem hiding this comment.
This shouldn't cause any user-facing changes.
The goal here is to improve code readability and maintainability.
|
I like that development builds are really fast, especially relative to other Rust projects I've contributed to. Would you want a check against build time regressions, to keep build times solid? I can look into adding that to CI in a future pull request if you're interested. |
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated!
Would you want a check against build time regressions, to keep build times solid?
I think when it happens and you notice it, I would rather like to welcome a PR to fix the regression if it is fixable at all.
The reason I wouldn't want complexity to be added to CI for this is that I believe it would have to be timing based, and that will be flaky too easily.
Thanks for your understanding.
If you have more ideas on contributions you'd like to make, please feel free to do it with a PR right away - I really want to keep your overhead low and the extra issue here didn't seem necessary.
|
You're welcome! We could add some leeway, maybe 10% of the average build time of a few runs, to circumvent some flakiness, but it's completely up to you. |
Closes #270