Fix styling for entries for interactive mode#62
Conversation
Signed-off-by: Maxim Zhukov <[email protected]>
Signed-off-by: Maxim Zhukov <[email protected]>
|
Thanks a lot! Much appreciated! I do wonder though why dimmed grey simply won't display for you - is it 'unsafe' to ever use it in TUIs? |
|
Version 2.10.1 was released. |
Hmmmm...
|
|
I am amazed by the effort you put into this reply, very neat to look at - thank you! This makes it easier for me to get used to the different color, too, as I now see that the contrast is too low in many color themes. |
|
On a similar note: the files are often not visible in the cli version as well.
Using a semi-transparent background |
|
@shilangyu try this patch diff --git a/src/aggregate.rs b/src/aggregate.rs
index 044f8e0..45df81a 100644
--- a/src/aggregate.rs
+++ b/src/aggregate.rs
@@ -111,9 +111,17 @@ pub fn aggregate(
fn path_color_of(path: impl AsRef<Path>) -> Option<Color> {
if path.as_ref().is_file() {
- Some(Color::BrightBlack)
- } else {
None
+ } else {
+ Some(Color::Cyan)
+ }
+}
+
+fn colorize_path(path: &Path, path_color: Option<colored::Color>) -> colored::ColoredString {
+ if let Some(path_color) = path_color {
+ path.display().to_string().as_str().color(path_color)
+ } else {
+ path.display().to_string().as_str().normal()
}
}
@@ -134,11 +142,7 @@ fn output_colored_path(
.to_string()
.as_str()
.green(),
- path.as_ref()
- .display()
- .to_string()
- .as_str()
- .color(path_color.unwrap_or(Color::White)),
+ colorize_path(path.as_ref(), path_color),
if num_errors == 0 {
Cow::Borrowed("")
} else { |
|
Would it be worth adding it to dua? Would maintain consistency between the cli and tui |
|
PR #63 was created |
This changeset replaced colors for entries in interactive mode
directory: from none to cyan
regular file: from dark gray to none
Before:
After:
